JeffM wrote:You must remember that bzflag was never meant to be used like it is these days.
It is a LAN game that was made for old hardware. It makes a lot of assumptions. If you want to figure out what the best "intent" was, figure on 30fps, with 10ms or less lag. That's how the game was first played.
Snick, it's not rubbish, it's just not what you expect it to be, or assumed it to be, and insults are not going to endear your ideas to anyone. Sure it's not great for internet play, that's true of the ENTIRE game.
There are no insults here. To say the code might be rubbish is not to insult anyone. I don't
think the code itself will be offended
Some of the code quality is dreadfully poor. That it was a LAN game is no excuse for that.
You could reasonably use the argument where lag is involved, but that's not relevant here.
For example, when a tank is hit, checkHit is supposed to determine the hit position. But it
doesn't. The position is always wrong by half a tank's height. And that's because the wrong
reference point is used in the code (centre of tank base rather than centre of tank). A lot
of the errors are simple stuff like that (remember how the mousebox was the wrong size?),
and it has little to do with LAN vs internet.
ps The half-tank error is still unfixed 5 months after I mentioned it. The fix is completely
trivial, by the way (just a few bytes and would take about 30 seconds to do). Here is the
conversation I had last Feb, from the IRC log:
11:06.55 randomparticle this is possibly wrong:
11:06.57 randomparticle position = tankPos + closestPos;
11:07.16 brlcad and it's possibly right, conjecture doesn't help
11:07.38 randomparticle it doesn't take account of the fact that the ray is relative to the centre of the tank, and the tank's position is relative to its base
11:07.58 randomparticle a bit more than conjecture, i think you'll find
11:08.26 brlcad then you should be able to find a specific example that is more than "possibly wrong"
11:13.25 randomparticle just bunging a console->addMessage in to prove my hypothesis
11:13.29 randomparticle one sec
11:22.22 randomparticle does look like the position returned by checkHit is always wrong
11:22.36 randomparticle it's off by half a tank's height
11:23.57 CIA-66 ow
11:24.09 randomparticle e.g., i shot myself on the ground. the position of the hit assigned had a Z value of 0.545
11:24.51 randomparticle but the muzzle height was 1.57
11:25.34 brlcad what's the tank height?
11:25.38 randomparticle 2.05
11:26.06 brlcad so gravity does kill
11:26.12 randomparticle :)
11:26.32 randomparticle 0.545 = (1.57 - 2.05/2)
I've removed a few smilies from that passage, because this forum won't accept more than 3.