Source 2.4.2 Tarballs, Compile Error

Questions or HOWTOs about the above? Post 'em here...
Post Reply
Enigma
Private First Class
Private First Class
Posts: 211
Joined: Sat Apr 23, 2005 3:13 am

Source 2.4.2 Tarballs, Compile Error

Post by Enigma »

Hey everyone,

I should probably submit this as a bug, but I'm not sure I remember my SourceForge login. I have so many passwords to remember it's not funny; Every time I login to pay my student loan, I have to reset my password because I enter it wrong too many times. Fun...

But anyways, I get this error:

Code: Select all

../../include/VotingArbiter.h:234:56: error: addition of default argument on redeclaration makes this constructor a default constructor
inline VotingArbiter::VotingArbiter(unsigned short int voteTime=60,
                                                       ^        ~~
../../include/VotingArbiter.h:89:3: note: previous declaration is here
  VotingArbiter(unsigned short int voteTime, unsigned short int vetoTime,
  ^
Someone got default initialization backwards. The default function arguments should be in the function declaration rather than the definition. It's an easy fix. Or maybe clang compilers are just more strict.

I was adding BZFlag to the Homebrew package manager on Mac, mostly to learn Ruby and Homebrew. I'll post my Ruby "formula" (link to GitHub) when I'm satisfied with my work.

Cheers,
Enigma
User avatar
JeffM
Staff Sergeant
Staff Sergeant
Posts: 5193
Joined: Fri Dec 13, 2002 4:11 am
Location: https://github.com/OmniTanks
Contact:

Re: Source 2.4.2 Tarballs, Compile Error

Post by JeffM »

that seems to have been fixed in the SVN/GitHub codebases.
ImageJeffM
Enigma
Private First Class
Private First Class
Posts: 211
Joined: Sat Apr 23, 2005 3:13 am

Re: Source 2.4.2 Tarballs, Compile Error

Post by Enigma »

Ok Cool, but it's still in

http://sourceforge.net/projects/bzflag/files/bzflag source/2.4.2/bzflag-2.4.2.tar.gz
http://sourceforge.net/projects/bzflag/files/bzflag source/2.4.2/bzflag-2.4.2.tar.bz2
User avatar
JeffM
Staff Sergeant
Staff Sergeant
Posts: 5193
Joined: Fri Dec 13, 2002 4:11 am
Location: https://github.com/OmniTanks
Contact:

Re: Source 2.4.2 Tarballs, Compile Error

Post by JeffM »

yes, that is an older version, we do not retroactively apply fixes to older version. We have not had a release with that fix in it.
ImageJeffM
Post Reply